Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update to Go 1.23 #3736

Merged
merged 3 commits into from
Jan 24, 2025
Merged

Update to Go 1.23 #3736

merged 3 commits into from
Jan 24, 2025

Conversation

turbolent
Copy link
Member

@turbolent turbolent commented Jan 24, 2025 •
edited
Loading

Description

Just like in flow-go, update to Go 1.23.

Go 1.24 is releasing next month, which will make 1.22 unsupported.

  • Targeted PR against master branch
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work
  • Code follows the standards mentioned here
  • Updated relevant documentation
  • Re-reviewed Files changed in the Github PR explorer
  • Added appropriate labels

@turbolent turbolent requested a review from jsproz January 24, 2025 17:42
@turbolent turbolent self-assigned this Jan 24, 2025
@turbolent turbolent requested a review from SupunS as a code owner January 24, 2025 17:42
@github-actions GitHub Actions
Copy link

Cadence Benchstat comparison

This branch with compared with the base branch onflow:master commit 86e7e4e
The command for i in {1..N}; do go test ./... -run=XXX -bench=. -benchmem -shuffle=on; done was used.
Bench tests were run a total of 7 times on each branch.

Collapsed results for better readability

@turbolent
Copy link
Member Author

@SupunS Had to fix new lint errors, see b81e414

turbolent
turbolent commented Jan 24, 2025
View reviewed changes
sema/type.go Show resolved Hide resolved
SupunS
SupunS approved these changes Jan 24, 2025
View reviewed changes
parser/declaration.go Show resolved Hide resolved
@turbolent turbolent merged commit 764dae5 into master Jan 24, 2025
11 of 12 checks passed
@turbolent turbolent deleted the bastian/update-go-1.23 branch January 24, 2025 19:31
@BrewTestBot BrewTestBot mentioned this pull request Jan 29, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SupunS SupunS SupunS approved these changes

@jsproz jsproz Awaiting requested review from jsproz

Assignees

@turbolent turbolent

Labels
Chore
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@turbolent @SupunS